Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed cached 'isEditing' state on history stack #230

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

Jonesy
Copy link
Contributor

@Jonesy Jonesy commented Aug 21, 2019

Description

If user's saved files to a new request and then refreshed, the cached history state of isEditing: true would start the page in edit mode, which would trigger an error as the uploading view of the table doesn't have the request ID to make a proper file request. Now once the edit is complete the state is replaced with isEditing set to false.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Jonesy Jonesy requested a review from ikethecoder August 21, 2019 18:02
@ikethecoder ikethecoder merged commit fbbca03 into develop Aug 21, 2019
@bdolor bdolor deleted the hotfix/issue-224-files-error branch November 26, 2019 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants