Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import size limits conflict with the max size for file validation #223

Closed
2 of 3 tasks
pripley123 opened this issue Aug 16, 2019 · 1 comment
Closed
2 of 3 tasks
Assignees
Labels
bug Something isn't working

Comments

@pripley123
Copy link
Collaborator

pripley123 commented Aug 16, 2019

As a researcher,

I want to be able to import file up to 20Mb

so that I can efficiently bring in documentation into the research environment that will assist my research.

Test Case

ENV

  • DEV
  • TEST
  • PROD

TESTCASE

  1. Create a new non-code import request.
  2. Upload a file of 19.5MB
  3. Upload a file of 20.1MB
  4. Click "Done Editing"
  5. Refresh the page (may need to give a bit of time for validation)

EXPECTED

Based on https://proj.data.gov.bc.ca/jira/browse/PROOF-1769 validation for import files...
19.MB file should have a warning icon next to it
20.1MB file should have an error icon next to it with a file size error message

ACTUAL

image.png
All files display multiple "File is too large to validate" errors. See attached screenshot.

@pripley123 pripley123 added the bug Something isn't working label Aug 16, 2019
@ikethecoder
Copy link
Member

ikethecoder commented Sep 4, 2019

There are three bits of work here:

  1. Rules currently do not distinguish between import vs export, so a "policy" needs to be added to the data model, the Policy API and the callers need to specify the policy name.

  2. The current "WORKING_LIMIT=5242880". This would need to be adjusted to cover the absolute max - which is 20Mb or 20971520 bytes.

  3. Bundled size logic in Request API needs to have config based on whether its an export vs import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants