Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning/Error file upload messages have duplicate text #164

Closed
1 of 3 tasks
pripley123 opened this issue Jul 10, 2019 · 1 comment
Closed
1 of 3 tasks

Warning/Error file upload messages have duplicate text #164

pripley123 opened this issue Jul 10, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pripley123
Copy link
Collaborator

pripley123 commented Jul 10, 2019

OCWA Issue

User Story

As a requester,

I want clear error/warning messages

so that I can more easily understand what I need to fix with my request.

Test Case

ENV

  • DEV
  • TEST
  • PROD

TESTCASE

  1. Create a new request
  2. Upload a file with study ids in it
  3. Refresh the page so that the error icon displays

EXPECTED

The error message text would be very clear and understandable.

ACTUAL

The error message is listed twice unnecessarily. It's also a bit weird how the "Failed" is prefixed to the error message. Having a colon between "Failed" and the error message would be clearer.
Annotation 2019-07-10 140623

@pripley123 pripley123 added the enhancement New feature or request label Jul 10, 2019
@Jonesy
Copy link
Contributor

Jonesy commented Jul 18, 2019

I have added some measures to prevent duplicate strings from being rendered here, but I think this is could more likely caused by the checkers in the API returning the same string in the message and error properties of the status object. The string fixes are in the hotfix/form-and-text-fixes which should be merged soon.

ikethecoder pushed a commit that referenced this issue Aug 22, 2019
@bdolor bdolor closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants