add waits for reports test case

bcgov · Jan 16, 2020 · 61554a4 · 61554a4
1 parent ba44ce5
commit 61554a4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/ui_tests/Include/scripts/groovy/test/ocwa/common/Constant.groovy b/ui_tests/Include/scripts/groovy/test/ocwa/common/Constant.groovy
@@ -13,6 +13,7 @@ public class Constant {
 	static final def FILE_UPLOAD_TIMEOUT = 5
 	static final def DOWNLOAD_INTERFACE_TIMEOUT = 2
 	static final def ASSIGN_TO_ME_TIMEOUT = 2
+	static final def STATUS_CHECK_WAIT = 2
 
 	final class Alerts {
 		static final def SUCCESS_UPDATED_TEXT = 'Successfully updated'

diff --git a/ui_tests/Include/scripts/groovy/test/ocwa/features/CheckerStep.groovy b/ui_tests/Include/scripts/groovy/test/ocwa/features/CheckerStep.groovy
@@ -100,6 +100,7 @@ public class CheckerStep extends Step {
 	def checker_should_see_request_is_in_given_status(String statusTxt) {
 		TestObject statusObj = Utils.getTestObjectByIdPart(Constant.Status.CHECKER_UI_REQUEST_STATUS_ID_PART, 'div')
 		WebUI.waitForElementPresent(statusObj, Constant.DEFAULT_TIMEOUT)
+		WebUI.delay(Constant.STATUS_CHECK_WAIT)
 		String actualStatusTxt = WebUI.getText(statusObj)
 		if (!actualStatusTxt.equals(statusTxt)) {
 			WebUI.takeScreenshot()

diff --git a/ui_tests/Include/scripts/groovy/test/ocwa/features/ReportStep.groovy b/ui_tests/Include/scripts/groovy/test/ocwa/features/ReportStep.groovy
@@ -51,7 +51,7 @@ import test.ocwa.common.Step
 import test.ocwa.common.Utils
 
 class ReportStep extends Step {
-	
+
 	@When("operational manager views the request in the reporting interface")
 	def view_request_milestones() {
 		//find the request in the reporting interface UI
@@ -67,7 +67,7 @@ class ReportStep extends Step {
 	@Then("the approved request should have a milestones for each status change")
 	def check_milestones_present() {
 		WebUI.waitForPageLoad(Constant.DEFAULT_TIMEOUT)
-		
+
 		//check that all status changes are present (assume it's an approved request)
 		TestObject statusObj = Utils.getTestObjectByIdPart(Constant.Status.REPORTS_UI_REQUEST_STATUS_ID_PART, 'div')
 		String statusTxt = Constant.Status.APPROVED
@@ -79,7 +79,9 @@ class ReportStep extends Step {
 			KeywordUtil.markFailed('Failing scenario because request is unexpected state.')
 		}
 		//check that the variable description field is populated
-		String varDesc = WebUI.getText(Utils.getTestObjectById(Constant.Reports.REPORTS_VARIABLE_TXT_ID))
+		TestObject varTextObj = Utils.getTestObjectById(Constant.Reports.REPORTS_VARIABLE_TXT_ID)
+		WebUI.waitForElementPresent(varTextObj, Constant.DEFAULT_TIMEOUT)
+		String varDesc = WebUI.getText(varTextObj)		
 		String expectedVariableDesc = Constant.Requester.REQUEST_VARIABLE_TEXT
 		if (!varDesc.equals(expectedVariableDesc )) {
 			WebUI.takeScreenshot()