fixes to some form sub routes

bcgov · Feb 4, 2020 · 327aa63 · 327aa63
1 parent d24eba4
commit 327aa63
Showing 1 changed file with 15 additions and 16 deletions.
diff --git a/microservices/requestApi/routes/v2/routes/requests.js b/microservices/requestApi/routes/v2/routes/requests.js
@@ -44,23 +44,20 @@ var getRouter = function(db){
     });
 
     router.post(FORMS_SUB_ROUTE, function(req, res, next){
-        try{
-            let adminGroup = config.get("adminGroup");
-            if (req.user.groups.indexOf(adminGroup) === -1){
-                res.status(403);
-                res.json({error: "Forbidden"});
-            }
-            formioClient.postForm(req.body, function(formErr, formRes){
-                if (formErr){
-                    res.status(500);
-                    res.json({error: formErr});
-                    return;
-                }
-                res.json(JSON.parse(formRes));
-            });
-        }catch(ex){
-            console.log("EXCEPTION WHILE POSTING FORM", ex);
+        var config = require('config');
+        let adminGroup = config.get("adminGroup");
+        if (req.user.groups.indexOf(adminGroup) === -1){
+            res.status(403);
+            res.json({error: "Forbidden"});
         }
+        formioClient.postForm(req.body, function(formErr, formRes){
+            if (formErr){
+                res.status(500);
+                res.json({error: formErr});
+                return;
+            }
+            res.json(JSON.parse(formRes));
+        });
     });
 
     router = routes.buildStatic(db, router);
@@ -482,6 +479,7 @@ var getRouter = function(db){
     });
 
     router.put(FORMS_SUB_ROUTE+'/:formName', function(req, res, next){
+        var config = require('config');
         let adminGroup = config.get("adminGroup");
         if (req.user.groups.indexOf(adminGroup) === -1){
             res.status(403);
@@ -499,6 +497,7 @@ var getRouter = function(db){
     });
 
     router.delete('/formio/:formName', function(req, res, next){
+        var config = require('config');
         var adminGroup = config.get("adminGroup");
 
         if (req.user.groups.indexOf(adminGroup) === -1){