Skip to content

Commit

Permalink
Fail fast if formio submission has validation errors
Browse files Browse the repository at this point in the history
  • Loading branch information
ikethecoder committed Jan 17, 2020
1 parent 9f6244c commit 073b8f0
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions microservices/requestApi/routes/v2/routes/requests.js
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,12 @@ var getRouter = function(db){
}
}

if (formRes.isJoi && formRes.name === "ValidationError") {
res.status(500);
res.json({error: "Critical form validation error"});
return;
}

request.submissionId = formRes._id;

request.save(function(saveErr, result){
Expand Down Expand Up @@ -269,6 +275,12 @@ var getRouter = function(db){
}
}

if (formRes.isJoi && formRes.name === "ValidationError") {
res.status(500);
res.json({error: "Critical form validation error"});
return;
}

db.Request.updateOne({_id: requestId}, findRes, function(saveErr){
if (saveErr) {
res.json({error: saveErr.message});
Expand Down

0 comments on commit 073b8f0

Please sign in to comment.