Add warning for ignored aspects #7332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
ujohnny
requested changes
Feb 18, 2025
| * The aspects should not be in the bazel ignore file. Emit a warning if any subpath of the aspect directory is | ||
| * mentioned in the bazel ignore file. | ||
| */ | ||
| private fun detectBazelIgnore(ctx: BlazeContext, aspectPath: Path) { |
There was a problem hiding this comment.
maybe not detect, but detectAndEmitWarning…
Emit a warning during sync if the aspects can be found in the bazel ignore file. The sync will most likely fail if the user has added the aspects to the bazel ignore file.
LeFrosch
force-pushed
the
bazel-ignore
branch
from
cdd4426 to
52b48d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit a warning during sync if the aspects can be found in the bazel ignore file. The sync will most likely fail if the user has added the aspects to the bazel ignore file.
Discussion thread for this change
Issue number: #7302, #7334