Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the toolchain transition for all toolchains. #14049

Closed

Conversation

katre
Copy link
Member

@katre katre commented Sep 27, 2021

RELNOTES: The toolchain transition is now enabled for all toolchains.

Closes #11584.

RELNOTES: The toolchain transition is now enabled for all toolchains.

Closes bazelbuild#11584.
@katre
Copy link
Member Author

katre commented Sep 27, 2021

@katre katre changed the title [WIP] Enable the toolchain transition for all toolchains. Enable the toolchain transition for all toolchains. Sep 27, 2021
@katre katre marked this pull request as ready for review September 27, 2021 17:00
@katre katre requested a review from gregestren September 27, 2021 17:00
@bazel-io bazel-io closed this in 4b47d6f Sep 27, 2021
@katre katre deleted the i11584-enable-toolchain-transition branch September 27, 2021 21:45
robfig added a commit to bazel-contrib/rules_go that referenced this pull request Dec 8, 2021
This allows us to find it at a known path.

It is no longer possible to access genfiles at a known path:
bazelbuild/bazel#14049

Fixes #2967
Fixes #3024
robfig added a commit to bazel-contrib/rules_go that referenced this pull request Dec 8, 2021
This allows us to find it at a known path.

It is no longer possible to access genfiles at a known path:
bazelbuild/bazel#14049

Fixes #2967
Fixes #3024
jbedard pushed a commit to bazel-contrib/rules_nodejs that referenced this pull request Jan 16, 2025
As documented at https://bazel.build/rules/lib/globals/bzl.html#rule:

    incompatible_use_toolchain_transition
    bool; default is False
    Deprecated, this is no longer in use and should be removed.

According to bazelbuild/bazel#14049, this
feature was enabled by default back in 2021.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incompatible_override_toolchain_transition: Migrate rules to use the toolchain transition
2 participants