[3/3] Bump grpc from 1.26.0 to 1.31.1 #12237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PART 1: prepare third_party/grpc files for new version Composed PR: bazelbuild#12226 Note: generate_cc.bzl and protobuf.bzl are modified in place and already affect the build. But the change seems to be harmless (adding explicit ProtoInfo load from @rules_proto). Fixes having external dependencies without checksum - boringssl (each download was timestamped, but otherwise stable) - bazel_skylark was overriden to be master (sic!) There doesn't seem to be many breaking/big changes up to grpc 1.31.1 - removal of xds-experimental URI scheme - removal of MAX_EPOLL_EVENTS_HANDLED_EACH_POLL_CALL - enable TLS 1.3 in the C-core and all wrapped languages - some of bazel-related patches got merged in https://github.com/grpc/grpc/releases How to check whether certain dependency has a checksum bazel query //external:bazel_skylib --output build bazel query //external:boringssl --output build How to find (almost?) all problematic dependencies compare output of bazel query 'kind(http_archive, //external:all) + kind(http_file, //external:all) + kind(distdir_tar, //external:all)' --output xml | xq '.query.rule[] | ."@name"' vs bazel query 'kind(http_archive, //external:all) + kind(http_file, //external:all) + kind(distdir_tar, //external:all)' --output xml | xq '.query.rule[] | select (.string[]."@name" | contains("sha256")) | ."@name"' Note that it looks for string sha256 and misses dict sha256 for distdir_tar rules - those are false positive currently.
PART 2: switch to grpc 1.31.1 Composed PR: bazelbuild#12226 Fixes having external dependencies without checksum - boringssl (each download was timestamped, but otherwise stable) - bazel_skylark was overriden to be master (sic!) There doesn't seem to be many breaking/big changes up to grpc 1.31.1 - removal of xds-experimental URI scheme - removal of MAX_EPOLL_EVENTS_HANDLED_EACH_POLL_CALL - enable TLS 1.3 in the C-core and all wrapped languages - some of bazel-related patches got merged in https://github.com/grpc/grpc/releases How to check whether certain dependency has a checksum bazel query //external:bazel_skylib --output build bazel query //external:boringssl --output build How to find (almost?) all problematic dependencies compare output of bazel query 'kind(http_archive, //external:all) + kind(http_file, //external:all) + kind(distdir_tar, //external:all)' --output xml | xq '.query.rule[] | ."@name"' vs bazel query 'kind(http_archive, //external:all) + kind(http_file, //external:all) + kind(distdir_tar, //external:all)' --output xml | xq '.query.rule[] | select (.string[]."@name" | contains("sha256")) | ."@name"' Note that it looks for string sha256 and misses dict sha256 for distdir_tar rules - those are false positive currently.
PART 3: remove grpc 1.26.0 from third_party/grpc Composed PR: bazelbuild#12226 Note: bootstrap jars & java_plugin remain to be 1.26.0 though Fixes having external dependencies without checksum - boringssl (each download was timestamped, but otherwise stable) - bazel_skylark was overriden to be master (sic!) There doesn't seem to be many breaking/big changes up to grpc 1.31.1 - removal of xds-experimental URI scheme - removal of MAX_EPOLL_EVENTS_HANDLED_EACH_POLL_CALL - enable TLS 1.3 in the C-core and all wrapped languages - some of bazel-related patches got merged in https://github.com/grpc/grpc/releases How to check whether certain dependency has a checksum bazel query //external:bazel_skylib --output build bazel query //external:boringssl --output build How to find (almost?) all problematic dependencies compare output of bazel query 'kind(http_archive, //external:all) + kind(http_file, //external:all) + kind(distdir_tar, //external:all)' --output xml | xq '.query.rule[] | ."@name"' vs bazel query 'kind(http_archive, //external:all) + kind(http_file, //external:all) + kind(distdir_tar, //external:all)' --output xml | xq '.query.rule[] | select (.string[]."@name" | contains("sha256")) | ."@name"' Note that it looks for string sha256 and misses dict sha256 for distdir_tar rules - those are false positive currently.
meteorcloudy
approved these changes
Oct 9, 2020
coeuvre
pushed a commit
to coeuvre/bazel
that referenced
this pull request
Oct 22, 2020
PART 3: remove grpc 1.26.0 from third_party/grpc Composed PR: bazelbuild#12226 Note: bootstrap jars & java_plugin remain to be 1.26.0 though Fixes having external dependencies without checksum - boringssl (each download was timestamped, but otherwise stable) - bazel_skylark was overriden to be master (sic!) There doesn't seem to be many breaking/big changes up to grpc 1.31.1 - removal of xds-experimental URI scheme - removal of MAX_EPOLL_EVENTS_HANDLED_EACH_POLL_CALL - enable TLS 1.3 in the C-core and all wrapped languages - some of bazel-related patches got merged in https://github.com/grpc/grpc/releases How to check whether certain dependency has a checksum bazel query //external:bazel_skylib --output build bazel query //external:boringssl --output build How to find (almost?) all problematic dependencies compare output of bazel query 'kind(http_archive, //external:all) + kind(http_file, //external:all) + kind(distdir_tar, //external:all)' --output xml | xq '.query.rule[] | ."@name"' vs bazel query 'kind(http_archive, //external:all) + kind(http_file, //external:all) + kind(distdir_tar, //external:all)' --output xml | xq '.query.rule[] | select (.string[]."@name" | contains("sha256")) | ."@name"' Note that it looks for string sha256 and misses dict sha256 for distdir_tar rules - those are false positive currently. Closes bazelbuild#12237
coeuvre
pushed a commit
to coeuvre/bazel
that referenced
this pull request
Oct 22, 2020
PART 3: remove grpc 1.26.0 from third_party/grpc Composed PR: bazelbuild#12226 Note: bootstrap jars & java_plugin remain to be 1.26.0 though Fixes having external dependencies without checksum - boringssl (each download was timestamped, but otherwise stable) - bazel_skylark was overriden to be master (sic!) There doesn't seem to be many breaking/big changes up to grpc 1.31.1 - removal of xds-experimental URI scheme - removal of MAX_EPOLL_EVENTS_HANDLED_EACH_POLL_CALL - enable TLS 1.3 in the C-core and all wrapped languages - some of bazel-related patches got merged in https://github.com/grpc/grpc/releases How to check whether certain dependency has a checksum bazel query //external:bazel_skylib --output build bazel query //external:boringssl --output build How to find (almost?) all problematic dependencies compare output of bazel query 'kind(http_archive, //external:all) + kind(http_file, //external:all) + kind(distdir_tar, //external:all)' --output xml | xq '.query.rule[] | ."@name"' vs bazel query 'kind(http_archive, //external:all) + kind(http_file, //external:all) + kind(distdir_tar, //external:all)' --output xml | xq '.query.rule[] | select (.string[]."@name" | contains("sha256")) | ."@name"' Note that it looks for string sha256 and misses dict sha256 for distdir_tar rules - those are false positive currently. Closes bazelbuild#12237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comes after #12236