Error upgrading module from 8.1.10 to 9.0.0

[subbu1993]

Pre-requisites

BV current version - 8.1.10
BV Updated version 9.0.0.

Issue

The 8.1.10 version does not have the bv_feed_include attribute, it is still called bv_feed_exclude

The setup scripts for version 9.0.0 first tries to add a note on the non-existent bv_feed_include attribute

magento2-extension/Setup/UpgradeData.php

Lines 133 to 144 in 9f7ee0f

	if (version_compare($context->getVersion(), '8.1.11') < 0) {
	/** @var CategorySetup $eavSetup */
	$eavSetup = $this->categorySetupFactory->create(['setup' => $setup]);
	$entityTypeId = $eavSetup->getEntityTypeId(Product::ENTITY);
	$eavSetup->updateAttribute(
	$entityTypeId,
	ProductFeed::INCLUDE_IN_FEED_FLAG,
	'note',
	'Not applicable to DCC'
	);
	}

before it can actually rename the attribute to bv_feed_include

magento2-extension/Setup/UpgradeData.php

Lines 164 to 171 in 9f7ee0f

	if ($eavSetup->getAttribute($entityTypeId, 'bv_feed_exclude')) {
	$eavSetup->updateAttribute(
	$entityTypeId,
	'bv_feed_exclude',
	'attribute_code',
	'bv_feed_include' //just fixes the code to reflect that it's been used as an include flag for years
	);
	}

This causes an error during setup:upgrade attribute bv_feed_include does not exist

Resolution

1. Move the rename to above the check for 8.11.0
   (or)
2. check in the 8.11.0 script if the bv_feed_include attribute exists

I can contribute a PR if you have a preferred approach. I personally prefer 1

[jantzenw]

Hi,

Thank you for bringing this to our attention. We've just pushed up a likely fix for this issue in the master branch, seen here: 986eec8

If you can install the master branch version of the extension, please do so and let us know if the above resolves the issue. Otherwise, this change will be in the next release.

Alternatively you can install and upgrade to, say, 8.3.5, and then after that, install and upgrade to 9.0.0. But that may not be feasible with long release schedules.

[drew7721]

https://i.imgur.com/oOG9cKk.png

Upgrading from 8.1.10 to 9.0.0 still errors out.

I don't believe the commit mentioned above fixed anything. The fact is that you're assuming these attributes to be there.
Unfortunately, this is not always the case. Maybe they were removed, maybe they were moved.

You should ALWAYS check if the attribute exists or not, kind of like what is done on this line.

magento2-extension/Setup/UpgradeData.php

Line 164 in 5dab3ed

if ($eavSetup->getAttribute($entityTypeId, 'bv_feed_exclude')) {

See this patch file for an example that would work.
bazaarvoice.txt

Let me know, I can make a PR need be.