-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proxy_get defined in riak-cs.conf not working [JIRA: RCS-236] #1185
Conversation
disabled -> false; | ||
Flag when is_boolean(Flag) -> Flag; | ||
Other -> | ||
_ = lager:warning("proxy_get value in riak.conf (advanced.config) is invalid: ~p", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/riak.conf/riak-cs.conf/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I was wrong.
Cuttlefish uses schema and validate values. One can not set any value other than boolean()
. If invalid value is set, advanced.config is probably wrong.
Nice fix. Works as advertised. Only one fix is needed for log message before 👍 |
Updated via web interface :P |
Fix proxy_get defined in riak-cs.conf not working [JIRA: RCS-236] Reviewed-by: shino
@borshop merge |
This is a bug made during 2.1 dev cycle, so release note for this is not needed. _[posted via JIRA by Kota Uenishi]_ |
This PR was closed BEFORE merge. Why? |
@borshop merge |
Fix proxy_get defined in riak-cs.conf not working [JIRA: RCS-236] Reviewed-by: shino
🎊 |
Without this code you'll have excessive log output like this by default:
This is because
riak_cs_config:proxy_get_active/0
handlesproxy_get_active
config item in riak-cs.config badly, only acceptingenabled/disabled
atom which could be set atadvanced.config
.