Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): timeout reload, go to next page instead #653

Merged
merged 1 commit into from
Nov 25, 2022
Merged

fix(core): timeout reload, go to next page instead #653

merged 1 commit into from
Nov 25, 2022

Conversation

nicolas-cusan
Copy link
Contributor

Fixes #475

@grappler grappler mentioned this pull request Jan 7, 2022
Closed
@xavierfoucrier xavierfoucrier marked this pull request as draft January 26, 2022 17:02
@xavierfoucrier xavierfoucrier added the bug bug to fix label Jan 26, 2022
@xavierfoucrier xavierfoucrier changed the base branch from master to dev January 27, 2022 09:00
@xavierfoucrier xavierfoucrier changed the base branch from dev to master January 27, 2022 09:00
@christophe-glanum
Copy link

Great fix ! When this fix will be released, please ? :)

@thibka
Copy link

thibka commented Jul 6, 2022

This fix seems to make sense: in case there's a problem loading the next page, it makes more sense to try to reload that next page rather than the current one!

I haven't properly tested it though, is there any reason to delay this merge?

@stepanjakl
Copy link

+1 to get this merged

@nicolas-cusan nicolas-cusan marked this pull request as ready for review November 2, 2022 09:58
@nicolas-cusan
Copy link
Contributor Author

Hi I just moved this from Draft to Open (did not know that that was even a thing with PRs, maybe it is new?). Would be great to get this merged. Thank you!

@xavierfoucrier xavierfoucrier self-assigned this Nov 25, 2022
@xavierfoucrier xavierfoucrier self-requested a review November 25, 2022 10:07
@xavierfoucrier xavierfoucrier changed the base branch from master to dev November 25, 2022 10:28
@xavierfoucrier
Copy link
Member

Hello @nicolas-cusan,

I change the PR state to draft months ago, in order to take time to check/test the fix on my side 👍
Now everything is OK, and I am merging it! 🎉

Sorry for the very long late reply, but we are all busy this year.

The fix shouldn't be available until a new package is released on NPM.

@xavierfoucrier xavierfoucrier merged commit 122772c into barbajs:dev Nov 25, 2022
@nicolas-cusan nicolas-cusan deleted the fix/timeout-reload branch November 25, 2022 13:09
@nicolas-cusan
Copy link
Contributor Author

Thank you @xavierfoucrier!

@xavierfoucrier xavierfoucrier added this to the barba@next milestone May 12, 2023
@xavierfoucrier xavierfoucrier mentioned this pull request May 12, 2023
Closed
15 tasks
@xavierfoucrier xavierfoucrier removed this from the barba@next milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavierfoucrier xavierfoucrier xavierfoucrier approved these changes

Assignees

@xavierfoucrier xavierfoucrier

Labels
bug bug to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page refreshed after timeout instead of redirected
5 participants
@nicolas-cusan @christophe-glanum @thibka @stepanjakl @xavierfoucrier