-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Simplify various login pages so that they look nice. #6570
Comments
Started doing some research, and the following resources came up at the time of writing this:
There's a few common suggestions in all of these articles:
|
@klonos Thanks for sharing your research. While all the examples |
All the UX research I have done so far suggests to "keep things simple" and "limit elements to the task at hand". When a user either intentionally clicks the "login" link from the home page of a site, or is redirected to the login form after trying to access a restricted section of the site, then the only task at hand is to log in - everything else is a distraction, which is not good UX. In the login form, the only links that should be available are:
The only UX pattern that I've seen (not explicitly being recommended - just mentioned) that has a login form integrated with the rest of the site is to provide the login form in a sidebar (what in Backdrop can be achieved with the "Login" block). But if a "login" link has been explicitly clicked, then the sole focus and best UX/workflow is to limit page elements to the login action. The above pattern made me think that opening the login form in a modal dialog, which pushes the rest of the site to the background and focuses on the form itself, should also be an acceptable UX. |
I'm assuming that that's because the screenshots are from "vanilla" installations. In Backdrop, we should be replacing the CMS logo with the actual site logo and name. It should be all about providing context to the person trying to log in that they are logging into the site - not promoting Backdrop in any way here. ...but perhaps we can consider adding a subtle "powered by Backdrop" link. If we decide to do that, then we should be respecting whether the "Powered by Backdrop" block has been removed from the default layout. In that case, we shouldn't be rendering anything related to the CMS. |
On a complex site I manage, there's a lot of members-only stuff, where an anonymous user sees text on a page that says something like "to access this stuff, please login and then return to this page." The link sends them to the login page with a |
I think that we already have an issue for that @bugfolder ...or something similar to that at least 👀 |
...there you go: #2207 🙂 |
I think Backdrop already does that OOTB; as long as cookies remain it keeps the session alive for quite a while. In my experience, sites that offer that through a checkbox still require occasional logging in. If we want to keep simple, then why clutter with a checkbox that probably won't make any difference? |
Yes, it does. And it is a security concern. The default should be to expose it as an option, with help text that says "Do not tick this if you are on a shared computer". (this feels like a separate issue though)
As I said, security concern. It can be optional (but denoted as recommended), and I would like to include it in #3624 as well. |
Here's an attempt to accomplish this with layouts. Borrowed code from @klonos #6569 and @sbgraphicdesign https://github.com/sbgraphicdesign/Backdrop-Custom-Login-Pages |
Thank you once again @docwilmot! 🙏🏼 ❤️ ...still a few missing bits from other issues/PRs, as well as some pending decisions/consensus, but I personally like where this is going 👍🏼 I know that @jenlampton has objections to adding another default layout, but I find it a reasonable/acceptable alternative (in #3309, some people expressed concerns when it comes to suppressing the layout in order to achieve this design). We can discuss that further in the next UX/design or dev meeting. Other than that:
|
They are if you clear caches. Ideally we'd be doing that when saving the "Manage blocks" form, and only be clearing specific caches if possible. |
I hope someone could mention it at a Thursday meeting so we can get some consensus.
It just a template; if users want more regions they can use another layout template, or modify this one.
We should actually need to add styles for all core themes
I think the ideal is to design a new Login Page Header Block with itself a template.
Its a layout; so users can just use the same template as the default, or whatever they like, if they don't want a special login page. For this PR we'd add an update hook to set the Login Page Layout to use the default template and blocks (also check if the existing site has overridden the login pages and use that template instead.
No, login block doesnt have password reset and new account pages.
Pages are cached for anonymous by default, I forgot. THats fixed now. |
@irinaz shared this on LinkedIn (thanks 🙏🏼 ), which I found a good read, and relevant to this issue here: https://matthewstrom.com/writing/ui-density |
@docwilmot not sure if you watched the recording from the dev meeting - I brought this issue up, but we were missing people to make a decision and move this forward. I'll make sure to bring it up during next week's dev meeting too. |
First, 💯 on this issue. I made similar changes to the Borg theme specifically because I wanted Backdrop's login page to feel less Drupally. This goes much further :) There is value to maintaining a site's branding (not CMS branding) on the log-in page so the current behavior should be preserved. However, having CMS branding there by default will be better for Backdrop -- if we do it right -- and I expect that's why many of the other examples show their own Branding there instead of anything to do with the sites themselves. As far as implementation:
|
So backdrop/backdrop#4750 then? |
This was discussed during the Design/UX meeting today, at 47:28 into the recording. Here: https://youtu.be/l2SAcL907AQ?t=2848 |
@jenlampton sounds like suppressing layouts is a preference, but I think there was quite a bit of negative reaction to suppressing layouts on the related PR, although I still think is the better option as per this comment. @jenlampton am I misinterpreting your comments? Eveeryone else change their mind toward accepting suppressing layouts? Curious how this will swing. |
I'm working on the test coverage and headings. |
backdrop/backdrop#4957 now includes test coverage for the new hooks and uses an |
Looks good to me! I've tested and reviewed the changes. Tests passing. The only thing left for a follow-up now is "Handle the theme-switch-by-config-or-UI". |
Perfect, all my (small) concerns addressed. Also RTBC from my side. We'll create an issue for the theme switch discussion proposed by @herbdool And maybe @olafgrabienski wants to further discuss the optimal logo dimensions? Neither of those needs to delay the merge here. |
Woo! Yay thank you @indigoxela! I wanted another review before merging. Thank you so much for providing many rounds of feedback on this pull request (whomever was working on it)! I have merged backdrop/backdrop#4957 into 1.x for 1.30.0! What an incredible improvement in our out-of-box experience. Moving forward, I imagine nearly all sites will prefer this new simplified system; unless they are specifically a community or member-based site (i.e. non-admins logging). And then those users can enjoy the new "tab-less" design. And of course it's backwards-compatible with the current (admittedly very poor) login experience. This could probably use a change record, despite not being an "API change", having a place to document use of the new hooks would be good. Big list of thank you's for this one: First and foremost, @docwilmot!! What an amazing effort to continuously try new solutions until one sticks. Not only that, but I think you knocked out like 4 issues simultaneously with this. Thank you!! But this was a huge team effort!
Overall, really grateful for our amazing community working together to make Backdrop friendlier and easier. Thank you everyone! backdrop/backdrop@2812d65 by @docwilmot, @argiepiano, @herbdool, @indigoxela, @quicksketch, @olafgrabienski, @klonos, @stpaultim, @bugfolder, @izmeez, @jenlampton, and @yorkshire-pudding. |
Follow-up created in #6799 - issue description needs some elaboration.
😂 timezone magic. 🪄 This issue and PR was a great demonstration of Backdrop CMS teamwork. 🎉 |
Moving this part of the discussion out of #3309, in order to not derail the recent momentum and direction of that issue.
The most recent PR in that issue provided an option to suppress the layout (regions other than the main content region), which resulted to this:

After some feedback, a border was added around the login form:

I proposed to use

0.25rem solid #bbbbbc
for the border in the login page, which is the same as the horizontal line used in the top-border of the footer in Basis (where Drop the dragon is sitting):...I tried to find any other borders used in blocks etc. in Basis that we could mimic, but couldn't find anything else.
If I was to suggest further styling for the login pages in Basis, then it would be to consider wrapping the h1 site name in a div, and styling it similarly to the header in Basis:

...we could add the same background pattern as the one used in the hero block:

...or make it plain black/white if people think it's "too much":

In general, I am looking for more consistency with the Basis theme.
In order to be as backwards-compatible as possible, we can offer a flip switch in the UI, to allow the legacy-styled login pages to be used on existing sites, as contrib and custom themes are adapted to accommodate for the new design/templates. This is a screenshot of what was in the PR sandbox at the time of writing vs. what I am proposing:

The wording in labels and help texts needs further thought/improvement, however the current "Use tabs" and "Hide regions" are too techie and don't sound like a new feature. They also do not explicitly convey what you get before/after.
Avocate: @docwilmot
The text was updated successfully, but these errors were encountered: