Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

[7.0] Rename flow AST Type NumericLiteralTypeAnnotation to NumberLiteralTypeAnnotation #329

Closed
danez opened this issue Jan 27, 2017 · 2 comments
Closed

[7.0] Rename flow AST Type NumericLiteralTypeAnnotation to NumberLiteralTypeAnnotation #329

danez opened this issue Jan 27, 2017 · 2 comments
Labels
good first issue Has PR help wanted Tag: Breaking Change
Milestone
7.0.0

Comments

@danez
Copy link
Member

danez commented Jan 27, 2017

Flow and babylon6 use a different node type for the following typeAnnotation:

var a : 1 = 1;

babylon uses NumericLiteralTypeAnnotation, whereas flow uses NumberLiteralTypeAnnotation

We should change babylon and rename the node to use the same name as flow.
@phpnode phpnode mentioned this issue Jan 27, 2017
Merged
@danez
Copy link
Member Author

danez commented Jan 27, 2017

We also need to do this change in babel itself. See babel/babel#5199 as a reference.

@phpnode phpnode mentioned this issue Jan 27, 2017
Merged
danharper added a commit to danharper/ast-types that referenced this issue Feb 1, 2017
@danharper
add Babel's NumericLiteralTypeAnnotation
ee217b0 
Flow's parser calls it NumberLiteralTypeAnnotation, and Babel will
switch to that naming convention in v7

babel/babylon#329
@danharper danharper mentioned this issue Feb 1, 2017
Merged
@hzoo
Copy link
Member

hzoo commented Feb 22, 2017

Done in babel/babel#5229

@hzoo hzoo closed this as completed Feb 22, 2017
@hzoo hzoo added this to the 7.0.0 milestone Feb 22, 2017
@wursttheke wursttheke mentioned this issue Feb 24, 2017
Closed
danharper added a commit to danharper/ast-types that referenced this issue Mar 9, 2017
@danharper
add Babel's NumericLiteralTypeAnnotation
6b7b5d3 
Flow's parser calls it NumberLiteralTypeAnnotation, and Babel will
switch to that naming convention in v7

babel/babylon#329
benjamn pushed a commit to benjamn/ast-types that referenced this issue Mar 12, 2017
@danharper @benjamn
add Babel's NumericLiteralTypeAnnotation (#205)
e38046d 
Flow's parser calls it NumberLiteralTypeAnnotation, and Babel will
switch to that naming convention in v7

babel/babylon#329
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Has PR help wanted Tag: Breaking Change
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
3 participants
@existentialism @danez @hzoo