-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Navigation will set parameters #1584
base: v2
Are you sure you want to change the base?
Conversation
continue; | ||
} | ||
|
||
// Shall we await this? This should be synchronous in most cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here another "TODO"
c0bfe13
to
97cff02
Compare
c3daea1
to
b2137f1
Compare
Just some paper-trail for our future selfs:
Assumption here is that we don't need the
While properly all of that (at least three reflection invocations plus some more setup to create * The CC: @egil |
640d486
to
46f5dfb
Compare
46f5dfb
to
6abd715
Compare
@egil I rebased all the work on |
6abd715
to
46e7ef6
Compare
Okay done :D - now the implementation is using our renderers That was a shortcoming that was easy to overcome with In any case many points are up to discussion. So we are not bored next Friday. |
46e7ef6
to
6ee39df
Compare
This closes #1580
The basic idea here is to have a router that takes care of everything. There are a few open points. I will mark them here. We can discuss this next Friday, I just had some time to do the feature today and wanted to finish it as much as possible.