Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve external APIs in the local build #211

Merged
merged 10 commits into from
Jan 17, 2024

Conversation

jcbsfilho
Copy link
Collaborator

Goal:

On the local Vulcan server, resolve external APIs with polyfill.
And in the production build, the APIs will be marked as external.

@jcbsfilho jcbsfilho marked this pull request as ready for review January 16, 2024 14:17
@jotanarciso
Copy link
Collaborator

jotanarciso commented Jan 16, 2024

I believe the polyfill should be in #env/polyfills. That is, this is an environment-adapted polyfill (#env), like fetchPolyfill, and should not appear in the final build artifacts. What do you think?

@jcbsfilho
Copy link
Collaborator Author

I believe the polyfill should be in #env/polyfills. That is, this is an environment-adapted polyfill (#env), like fetchPolyfill, and should not appear in the final build artifacts. What do you think?

I agree, let's move the external polyfills to the #env/polyfills path.
External polyfills are resolved in build, but are separated between build/polyfills and env/polyfills.

jotanarciso
jotanarciso previously approved these changes Jan 16, 2024
Copy link
Collaborator

@jotanarciso jotanarciso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@jotanarciso jotanarciso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as expected. LGTM!

@jcbsfilho jcbsfilho merged commit b265ed6 into stage Jan 17, 2024
@jcbsfilho jcbsfilho deleted the feat/external-api-runtime branch January 17, 2024 17:49
tiagokrebs pushed a commit that referenced this pull request Jan 17, 2024
[skip ci]
## [2.3.0-stage.1](v2.2.0...v2.3.0-stage.1) (2024-01-17)

### Features

* added building with external api to local runtime ([52bcd13](52bcd13))
* adding partial implementation of async_hooks to local dev ([3665359](3665359))
* resolve external APIs in the local build ([#211](#211)) ([b265ed6](b265ed6))
@tiagokrebs
Copy link
Contributor

🎉 This PR is included in version 2.3.0-stage.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

tiagokrebs pushed a commit that referenced this pull request Jan 22, 2024
[skip ci]
## [2.3.0](v2.2.0...v2.3.0) (2024-01-22)

### Features

* added building with external api to local runtime ([52bcd13](52bcd13))
* adding partial implementation of async_hooks to local dev ([3665359](3665359))
* resolve external APIs in the local build ([#211](#211)) ([b265ed6](b265ed6))

### Bug Fixes

* angular deliver preset ([#215](#215)) ([5bb2d77](5bb2d77))
* angular preset (deliver) ([f8c12b6](f8c12b6))
* remove versionid ([482fb35](482fb35))
* remove versionid ([#210](#210)) ([e78ea1e](e78ea1e))
@tiagokrebs
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants