fix: angular deliver preset #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotanarciso
requested review from
MagnunAVFAzion,
enicio,
jcbsfilho and
tiagokrebs
as code owners
jotanarciso
force-pushed
the
fix/angular-deliver-preset
branch
from
4717fa5 to
f8c12b6
Compare
lmalheiro
approved these changes
Jan 22, 2024
jcbsfilho
approved these changes
Jan 22, 2024
maxwelbm
approved these changes
Jan 22, 2024
|
🎉 This PR is included in version 2.3.0-stage.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tiagokrebs
pushed a commit
that referenced
this pull request
Jan 22, 2024
[skip ci] ## [2.3.0](v2.2.0...v2.3.0) (2024-01-22) ### Features * added building with external api to local runtime ([52bcd13](52bcd13)) * adding partial implementation of async_hooks to local dev ([3665359](3665359)) * resolve external APIs in the local build ([#211](#211)) ([b265ed6](b265ed6)) ### Bug Fixes * angular deliver preset ([#215](#215)) ([5bb2d77](5bb2d77)) * angular preset (deliver) ([f8c12b6](f8c12b6)) * remove versionid ([482fb35](482fb35)) * remove versionid ([#210](#210)) ([e78ea1e](e78ea1e))
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the new version of Angular (which is initialized by default by the Azion CLI) it has SSR functionalities. As a result, the folder structure resulting from the build has a new subdivision: Browser and Server. We currently only support code on the Browser side (in deliver mode).
Resolution
This PR moves the contents of the '.edge/storage/browser' folder to the root of the storage (.edge/storage/) and displays an alert if the user is using SSR resources.