Filterx allow stack based string wrappers #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
filterx-allow-stack-based-string-wrappers
branch
from
8f3cac8 to
6f96b60
Compare
alltilla
reviewed
Feb 5, 2025
|
Thinking a bit more about concurrency, I don't even see how FilterXObjects can be accessed from multiple threads. I saw the atomic operations and my mind clicked to concurrency mode. Can you help me out about why we have atomic counters here? I think if it is not necessary we either should not use atomic counters at all or we should write the code with the mindset that the refcounters can be changed concurrently, in which case my review comments stand. |
bazsi
force-pushed
the
filterx-allow-stack-based-string-wrappers
branch
2 times, most recently
from
bacdbc1 to
1ea3983
Compare
alltilla
force-pushed
the
filterx-allow-stack-based-string-wrappers
branch
from
1ea3983 to
f10f3fc
Compare
alltilla
approved these changes
Feb 7, 2025
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
…ecast Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
…BJECT_REFCOUNT_FROZEN Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Instances of strings that are only used once for a brief period can be allocated on the stack to reduce malloc() calls. This is especially useful when iterating over a lot of FilterXString instances, most of which is imediately dropped away. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Clarify the races involved and also trigger an abort on use-after-free. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
bazsi
force-pushed
the
filterx-allow-stack-based-string-wrappers
branch
from
f10f3fc to
6b3afc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables filterx code to create short-lived FilterXString instances on the stack.
Such instances
The PR also contains a number of conversions from allocation based FilterXString instances to these, reducing the
total number of malloc() calls significantly for unset_empties(), parse_csv() and parse_kv()