Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filterx expr constructor improvements #445

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

bazsi
Copy link
Member

@bazsi bazsi commented Jan 7, 2025

Next out of #434, this time it is based on #444 that needs to go in first.

There are two patches here (on top of #444):

  • the nullv style constructors are reimplemented as a "delta" to the normal constructor to avoid code duplication
  • _eval() methods are renamed everywhere so it's easier to read perf stackdumps

@bazsi bazsi force-pushed the filterx-expr-constructor-improvements branch from 1789f6e to c51dfbc Compare January 11, 2025 11:47
@alltilla alltilla self-requested a review January 14, 2025 10:38
@bazsi bazsi force-pushed the filterx-expr-constructor-improvements branch 3 times, most recently from 8e44174 to 282bad3 Compare January 22, 2025 09:58
bazsi added 2 commits January 22, 2025 10:58
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
To make it easier to understand stackdumps.

Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
@bazsi bazsi force-pushed the filterx-expr-constructor-improvements branch from 282bad3 to b293f41 Compare January 22, 2025 09:59
@bazsi
Copy link
Member Author

bazsi commented Jan 22, 2025

rebased against master to resolve conflicts.

@alltilla alltilla merged commit 74fb889 into axoflow:main Jan 22, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants