Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update aws-cloudfront-apigateway to use CloudFront Functions instead of Lambda@Edge #295

Closed
2 tasks
biffgaut opened this issue Aug 2, 2021 · 0 comments · Fixed by #272 or #313
Closed
2 tasks

update aws-cloudfront-apigateway to use CloudFront Functions instead of Lambda@Edge #295

biffgaut opened this issue Aug 2, 2021 · 0 comments · Fixed by #272 or #313
Assignees
@hnishar
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged

Comments

@biffgaut
Copy link
Contributor

biffgaut commented Aug 2, 2021

Currently this constructs uses Lambda@Edge functions to inject security headers. As such, it can only be launched in us-east-1 and destroying the stack has to be completed manually. CloudFront functions perform the same functionality without these limitations. This is similar to the implementation of aws-cloudfront-s3.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@biffgaut biffgaut added feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged labels Aug 2, 2021
hnishar added a commit that referenced this issue Aug 7, 2021
@hnishar
fix (CloudFrontToApiGateway - use cloudfront function instead of lamb…
938ee6e 
…da@edge) (#295)
@hnishar hnishar mentioned this issue Aug 7, 2021
Merged
@hnishar hnishar linked a pull request Aug 7, 2021 that will close this issue
fix (CloudFrontToS3 - use cloudfront function instead of lambda@edge) #272
Merged
@biffgaut biffgaut linked a pull request Aug 9, 2021 that will close this issue
fix (CloudFrontToApiGateway - use cloudfront function instead of lambda@edge) #313
Merged
biffgaut added a commit that referenced this issue Aug 9, 2021
@hnishar @biffgaut
fix (CloudFrontToApiGateway - use cloudfront function instead of lamb…
7ed052c 
…da@edge) (#295) (#313)

Co-authored-by: biffgaut <78155736+biffgaut@users.noreply.github.com>
biffgaut pushed a commit that referenced this issue Aug 9, 2021
@hnishar
fix (CloudFrontToMediaStore - use cloudfront function instead of lamb…
fd753f1 
…da@edge) (#317)

* fix (CloudFrontToApiGateway - use cloudfront function instead of lambda@edge) (#295)

* fix (CloudFrontToMediStore - use cloudfront function instead of lambda@edge) (#296)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hnishar hnishar

Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged
Projects
None yet
Milestone
No milestone
2 participants
@hnishar @biffgaut