chore: update smithy version to 1.22.0 #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2022 16:05
## Motivation #597 is failing due to unresolved shape `smithy.api#Unit` which was introduced in smithy-lang/smithy#980 ## Changes Updated smithyVersion to 1.22.0. ## Result AWS SDK handles `smithy.api#Unit` for operation correctly.
ganeshnj
changed the title
2 tasks
ianbotsf
approved these changes
Aug 10, 2022
sugmanue
approved these changes
Aug 10, 2022
hectormatos2011
approved these changes
Aug 11, 2022
ganeshnj
added a commit
to smithy-lang/smithy-swift
that referenced
this pull request
Aug 11, 2022
## Motivation awslabs/aws-sdk-swift#597 is failing due to unresolved shape smithy.api#Unit which was introduced in smithy-lang/smithy#980 ## Changes - Updated smithyVersion to 1.22.0. - Update smithyGradleVersion to 0.6.0 - Fix issues with header list parsing. The parsing was always correct but the test setup was not, where expected result always assumed that the list is a date list. To support this, I took kotlin implementation of string list parsing and translated to Swift with test cases. - JsonName trait now has no effect in AwsJson1_0 and AwsJson1_1, this change is covered at chore: update smithy version to 1.22.0 aws-sdk-swift#600 - serde change: in case where the top container is sparse map which contains a dense list as value, the dense list was considered as sparse. Therefore, added a way to track the member parent to fix the nullability. - Sensitive trait fixes because now it can't target member directly. ## Result awslabs/aws-sdk-swift#600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(#597 is failing due to unresolved shape
smithy.api#Unitwhich was introduced in smithy-lang/smithy#980)Description of changes
JsonNametrait now has no effect in AwsJson1_0 and AwsJson1_1, this change is supported by chore: update smithy version to 1.22.0 smithy-lang/smithy-swift#425New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.