Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended kubernetes version support validations for create and upgrade CLI operations #9225

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

panktishah26
Copy link
Member

Issue #, if available:
#6793

Description of changes:
Validate extended kubernetes version support for eks-a create and upgrade CLI operations.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.33%. Comparing base (30fa933) to head (a50bebe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/eksctl-anywhere/cmd/validatecreatecluster.go 0.00% 2 Missing ⚠️
cmd/eksctl-anywhere/cmd/createcluster.go 0.00% 1 Missing ⚠️
cmd/eksctl-anywhere/cmd/upgradecluster.go 0.00% 1 Missing ⚠️
pkg/providers/tinkerbell/upgrade.go 0.00% 1 Missing ⚠️
pkg/validations/extendedversion.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9225      +/-   ##
==========================================
+ Coverage   72.32%   72.33%   +0.01%     
==========================================
  Files         587      587              
  Lines       46081    46108      +27     
==========================================
+ Hits        33328    33353      +25     
- Misses      11003    11005       +2     
  Partials     1750     1750              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26 panktishah26 force-pushed the extended-k8s-support-cli branch from 7fb9c91 to f7f51e3 Compare February 6, 2025 20:45
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 6, 2025
@panktishah26 panktishah26 force-pushed the extended-k8s-support-cli branch from f7f51e3 to c4a0a4c Compare February 6, 2025 20:58
func() *validations.ValidationResult {
return &validations.ValidationResult{
Name: "validate extended kubernetes version support is supported",
Remediation: "ensure you have a valid license to support extended kubernetes version support",
Copy link
Member

@jacobweinstock jacobweinstock Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Remediation: "ensure you have a valid license to support extended kubernetes version support",
Remediation: "ensure you have a valid license for extended Kubernetes version support",

func() *validations.ValidationResult {
return &validations.ValidationResult{
Name: "validate extended kubernetes version support is supported",
Remediation: "ensure you have a valid license to support extended kubernetes version support",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Remediation: "ensure you have a valid license to support extended kubernetes version support",
Remediation: "ensure you have a valid license for extended Kubernetes version support",

@panktishah26 panktishah26 force-pushed the extended-k8s-support-cli branch from e8a5369 to a50bebe Compare February 6, 2025 23:17
@eks-distro-bot
Copy link
Collaborator

eks-distro-bot commented Feb 7, 2025

@panktishah26: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-anywhere-release-tooling-test-presubmit 7fb9c91 link true /test eks-anywhere-release-tooling-test-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@panktishah26
Copy link
Member Author

/retest

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit a337550 into aws:main Feb 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants