-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extended kubernetes version support validations for create and upgrade CLI operations #9225
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9225 +/- ##
==========================================
+ Coverage 72.32% 72.33% +0.01%
==========================================
Files 587 587
Lines 46081 46108 +27
==========================================
+ Hits 33328 33353 +25
- Misses 11003 11005 +2
Partials 1750 1750 ☔ View full report in Codecov by Sentry. |
7fb9c91
to
f7f51e3
Compare
f7f51e3
to
c4a0a4c
Compare
func() *validations.ValidationResult { | ||
return &validations.ValidationResult{ | ||
Name: "validate extended kubernetes version support is supported", | ||
Remediation: "ensure you have a valid license to support extended kubernetes version support", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remediation: "ensure you have a valid license to support extended kubernetes version support", | |
Remediation: "ensure you have a valid license for extended Kubernetes version support", |
func() *validations.ValidationResult { | ||
return &validations.ValidationResult{ | ||
Name: "validate extended kubernetes version support is supported", | ||
Remediation: "ensure you have a valid license to support extended kubernetes version support", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remediation: "ensure you have a valid license to support extended kubernetes version support", | |
Remediation: "ensure you have a valid license for extended Kubernetes version support", |
c4a0a4c
to
e8a5369
Compare
…grade CLI operations
e8a5369
to
a50bebe
Compare
@panktishah26: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
#6793
Description of changes:
Validate extended kubernetes version support for eks-a create and upgrade CLI operations.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.