Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI commands support for packages in airgapped admin #8026

Merged
merged 1 commit into from
May 2, 2024

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Apr 22, 2024

Issues
https://github.com/aws/eks-anywhere-internal/issues/2252
https://github.com/aws/eks-anywhere-internal/issues/2270

Description of changes:
Below changes ensure that if a customer has a registry mirror setup as part of their EKS-A cluster config; we ensure to perform eksctl anywhere CLI commands for packages using the mirror.

This is significant for folks with an airgapped admin machine; when running these commands the CLI dependencies will know to be pulled from their mirror and not use public.ecr.aws .
Testing:

./eksctl-anywhere install packagecontroller -f ./regauth-cluster/regauth-cluster-eks-a-cluster.yaml

./eksctl-anywhere generate package harbor --cluster ramaliar-tink-regauth --kubeconfig ./regauth-cluster/regauth-cluster-eks-a-cluster.kubeconfig

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 73.40%. Comparing base (443a57f) to head (127ac54).
Report is 31 commits behind head on main.

Files Patch % Lines
cmd/eksctl-anywhere/cmd/generatepackage.go 0.00% 12 Missing ⚠️
cmd/eksctl-anywhere/cmd/common.go 0.00% 8 Missing ⚠️
...md/eksctl-anywhere/cmd/installpackagecontroller.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8026      +/-   ##
==========================================
- Coverage   73.44%   73.40%   -0.05%     
==========================================
  Files         577      577              
  Lines       35875    35896      +21     
==========================================
  Hits        26348    26348              
- Misses       7861     7882      +21     
  Partials     1666     1666              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pokearu
Copy link
Member Author

pokearu commented May 2, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pokearu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pokearu pokearu merged commit 71dea4b into aws:main May 2, 2024
10 of 12 checks passed
@sp1999
Copy link
Member

sp1999 commented Oct 18, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8865

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants