-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear resource version before updating management components version #7787
Clear resource version before updating management components version #7787
Conversation
Skipping CI for Draft Pull Request. |
cca1f2c
to
3e39cff
Compare
3e39cff
to
82d5d26
Compare
/hold Running the test again |
82d5d26
to
0722b8c
Compare
/unhold |
0722b8c
to
63318d8
Compare
/hold Working of addressing unit test failures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7787 +/- ##
==========================================
+ Coverage 73.48% 73.61% +0.13%
==========================================
Files 579 588 +9
Lines 36357 37175 +818
==========================================
+ Hits 26718 27368 +650
- Misses 7875 8015 +140
- Partials 1764 1792 +28 ☔ View full report in Codecov by Sentry. |
/unhold |
/unhold |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cxbrowne1207 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.19 |
@cxbrowne1207: new pull request created: #7799 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Description of changes:
After the CLI is upgrading the core components, we update the management components version annotation on the
Cluster
object using a server-side apply. Despite retrieving the most recent version of the object before performing the update, there can be a case where the object has been updated by another process in the meantime (e.g. the controller). This creates conflict, the update will fail and a retry is suggestedThis PR clears the resource version of the
Cluster
object before applying. This avoids triggering the api server to detect a conflict if the resource versions are different.Error message
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.