Adding quotes for datacenter field

[adonskoy]

Issue #, if available: #3381

Description of changes:
Added quotes to the spec.template.spec.datacenter value in VSphereMachineTemplate to ensure that the value type is always a string.

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[eks-distro-bot]

Hi @adonskoy. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[TerryHowe]

/ok-to-test

[TerryHowe]

uugn, I could see one or two test failures, but way too many dependencies on that.

[codecov]

Codecov Report

Merging #3382 (894e646) into main (fe8ada3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3382   +/-   ##
=======================================
  Coverage   64.85%   64.85%           
=======================================
  Files         352      352           
  Lines       28395    28395           
=======================================
  Hits        18416    18416           
  Misses       8666     8666           
  Partials     1313     1313           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[vivek-koppuru]

This is a great find, thank you for sharing this! Now my question is, should we do this for the other string values in this file as well if they can support only integers as well?

[adonskoy]

This is a great find, thank you for sharing this! Now my question is, should we do this for the other string values in this file as well if they can support only integers as well?

As far as I can see, other values cannot be integers in this file, because they will either initially be a string, or are the result of concatenating other strings (for example, datastore)

[vivek-koppuru]

This is a great find, thank you for sharing this! Now my question is, should we do this for the other string values in this file as well if they can support only integers as well?

As far as I can see, other values cannot be integers in this file, because they will either initially be a string, or are the result of concatenating other strings (for example, datastore)

Good point, I think these changes are good then!

[vivek-koppuru]

/approve

[eks-distro-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vivek-koppuru

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vivek-koppuru]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vivek-koppuru]

@adonskoy Can you rebase the changes in your branch and add this change to the expected_results_minimal_autoscaling_md.yaml file in the vsphere package as well? Seems to be a new test file

[vivek-koppuru]

/cherry-pick release-0.11

[eks-distro-pr-bot]

@vivek-koppuru: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eks-distro-pr-bot]

@vivek-koppuru: new pull request created: #3406

In response to this:

/cherry-pick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vivek-koppuru]

@adonskoy Thank you so much for your contribution!