Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature flag for kubernetes version 1.23 #2891

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

mitalipaygude
Copy link
Contributor

@mitalipaygude mitalipaygude commented Aug 5, 2022

Issue #, if available:
#2159

Description of changes:
Remove feature flag for kubernetes version 1.23

Testing (if applicable):

  • make
  • make e2e

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #2891 (c145c79) into main (127164d) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2891      +/-   ##
==========================================
+ Coverage   61.57%   61.60%   +0.03%     
==========================================
  Files         323      323              
  Lines       26364    26356       -8     
==========================================
+ Hits        16233    16237       +4     
+ Misses       8860     8848      -12     
  Partials     1271     1271              
Impacted Files Coverage Δ
pkg/features/features.go 11.11% <ø> (+1.35%) ⬆️
pkg/validations/cluster.go 88.46% <ø> (+0.96%) ⬆️
...idations/createvalidations/preflightvalidations.go 0.00% <ø> (ø)
...dations/upgradevalidations/preflightvalidations.go 100.00% <ø> (ø)
pkg/gitops/flux/client.go 100.00% <0.00%> (ø)
pkg/gitops/flux/flux.go 84.09% <0.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mitalipaygude
Copy link
Contributor Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mitalipaygude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 376f3c9 into aws:main Aug 5, 2022
@mitalipaygude mitalipaygude deleted the 1.23_feature branch June 18, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants