Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for 1.23 Bottlerocket #2379

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

mitalipaygude
Copy link
Contributor

Issue #, if available:
#2159
Description of changes:

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #2379 (7683e8a) into main (9a8e1b1) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2379      +/-   ##
==========================================
- Coverage   51.93%   51.84%   -0.10%     
==========================================
  Files         318      320       +2     
  Lines       26359    26737     +378     
==========================================
+ Hits        13690    13862     +172     
- Misses      11368    11565     +197     
- Partials     1301     1310       +9     
Impacted Files Coverage Δ
pkg/workflows/diagnostics.go 55.55% <0.00%> (-23.40%) ⬇️
pkg/workflows/delete.go 50.00% <0.00%> (-11.67%) ⬇️
pkg/workflows/upgrade.go 51.65% <0.00%> (-10.39%) ⬇️
pkg/providers/tinkerbell/hardware/machine.go 73.80% <0.00%> (-7.15%) ⬇️
pkg/workflows/create.go 45.99% <0.00%> (-4.83%) ⬇️
pkg/providers/tinkerbell/validate.go 82.66% <0.00%> (-3.45%) ⬇️
pkg/cluster/flux.go 78.94% <0.00%> (-1.49%) ⬇️
pkg/providers/tinkerbell/template.go 33.53% <0.00%> (-1.45%) ⬇️
pkg/providers/snow/snow.go 53.54% <0.00%> (-1.42%) ⬇️
pkg/providers/tinkerbell/create.go 46.42% <0.00%> (-0.80%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8e1b1...7683e8a. Read the comment docs.

)
runConformanceFlow(test)
}

func TestVSphereKubernetes122BottleRocketThreeWorkersConformanceFlow(t *testing.T) {
func TestCloudStackKubernetes120ThreeWorkersConformanceFlow(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want newer version cloudstack tests? Maybe we don't have that template?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't spoken to anyone from the cloudstack team yet, I can check with them.

@vivek-koppuru
Copy link
Member

/lgtm

@mitalipaygude
Copy link
Contributor Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mitalipaygude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 83db866 into aws:main Jun 13, 2022
@mitalipaygude mitalipaygude deleted the br_tests branch July 6, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants