Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: font color for high contrast themes #5298

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: font color for high contrast themes #5298

merged 1 commit into from
Jul 11, 2024

Conversation

ivikash
Copy link
Member

@ivikash ivikash commented Jul 11, 2024 •
edited
Loading

Font color for high contrast themes to fix #5294

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ivikash ivikash requested a review from a team as a code owner July 11, 2024 17:16
justinmk3
justinmk3 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a button color in that theme that can make the button stand out?

@ivikash
Copy link
Member Author

ivikash commented Jul 11, 2024

Is there a button color in that theme that can make the button stand out?

Thats a great suggestion. I will update it in the next revision.

@ivikash ivikash force-pushed the fix/auth-ui-high-contrast branch from ba830f4 to 2c48b00 Compare July 11, 2024 19:26
@ivikash
Copy link
Member Author

ivikash commented Jul 11, 2024 •
edited
Loading

Theme Continue Button Disabled Continue Button Active and Keyboard Navigation User Input Authenticating
High Contrast Dark Screenshot 2024-07-11 at 12 19 35 PM Screenshot 2024-07-11 at 12 20 18 PM Screenshot 2024-07-11 at 12 20 34 PM Screenshot 2024-07-11 at 12 20 23 PM
High Contrast Light Screenshot 2024-07-11 at 12 20 46 PM Screenshot 2024-07-11 at 12 20 54 PM Screenshot 2024-07-11 at 12 20 59 PM Screenshot 2024-07-11 at 12 21 08 PM
Dark Theme Screenshot 2024-07-11 at 12 22 03 PM Screenshot 2024-07-11 at 12 22 10 PM Screenshot 2024-07-11 at 12 22 14 PM Screenshot 2024-07-11 at 12 22 20 PM
High Contrast Dark Screenshot 2024-07-11 at 12 24 17 PM Screenshot 2024-07-11 at 12 24 22 PM Screenshot 2024-07-11 at 12 24 26 PM
Screenshot 2024-07-11 at 12 24 45 PM		 Screenshot 2024-07-11 at 12 44 04 PM
High Contrast Light Screenshot 2024-07-11 at 12 25 05 PM Screenshot 2024-07-11 at 12 25 09 PM Screenshot 2024-07-11 at 12 25 17 PM
Screenshot 2024-07-11 at 12 43 39 PM		 Screenshot 2024-07-11 at 12 25 21 PM
Dark Theme Screenshot 2024-07-11 at 12 23 44 PM Screenshot 2024-07-11 at 12 23 51 PM Screenshot 2024-07-11 at 12 23 57 PM Screenshot 2024-07-11 at 12 24 02 PM
Reauthenticate Dark Theme High Contrast High Contrast Light
Screenshot 2024-07-11 at 12 53 41 PM Screenshot 2024-07-11 at 12 54 27 PM Screenshot 2024-07-11 at 12 53 55 PM

@ivikash ivikash force-pushed the fix/auth-ui-high-contrast branch from 2c48b00 to 6d256d8 Compare July 11, 2024 19:54
@ivikash ivikash merged commit dfb90ac into aws:master Jul 11, 2024
13 of 14 checks passed
@ivikash ivikash deleted the fix/auth-ui-high-contrast branch July 11, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk3 justinmk3 justinmk3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Black on Black text on "Dark High Contrast" theme
2 participants
@ivikash @justinmk3