feat: globalState abstraction

[justinmk3]

Problem

We have a settings.ts module which abstracts the vscode settings interface, to gain important features such as type-checking, validation, and error handling.

The vscode globalState interface is very similar to the vscode settings interface, and has the same limitations and potential for bugs: the data is user-defined and arbitrary, thus the types are unknown and must always be runtime-checked, which is a verbose and often overlooked step.

Examples:

• redshiftState.ts https://github.com/aws/aws-toolkit-vscode-staging/pull/1034/files

• aws-toolkit-vscode/src/shared/filesystemUtilities.ts

  Lines 230 to 250 in 8f55e40

  	*/
  	export function getDefaultDownloadPath(): string {
  	const lastUsedPath = globals.context.globalState.get('aws.downloadPath')
  	if (lastUsedPath) {
  	if (typeof lastUsedPath === 'string') {
  	return lastUsedPath
  	}
  	getLogger().error('Expected "aws.downloadPath" to be string, got %O', typeof lastUsedPath)
  	}
  	return downloadsDir()
  	}
  	export async function setDefaultDownloadPath(downloadPath: string) {
  	try {
  	const savePath = await stat(downloadPath)
  	if (savePath.isDirectory()) {
  	globals.context.globalState.update('aws.downloadPath', downloadPath)
  	} else {
  	globals.context.globalState.update('aws.downloadPath', path.dirname(downloadPath))
  	}
  	} catch (err) {

• globalState type issues related to a codewhisperer bug: codewhisperer: fix var assign error and move timestamp save #3060
• aws.lastUploadedToS3Folder https://github.com/aws/aws-toolkit-vscode/pull/3183/files
• ExtensionUse class https://github.com/aws/aws-toolkit-vscode/pull/3634/files
• codewhisperer/util/globalStateUtil.test.ts

Solution

• Introduce a globalState wrapper, similar to src/shared/settings.ts.
• Migrate the redshiftState.ts module into the centralized globalState module.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[justinmk3]

/runintegrationtests