fix: Resolve symlinks on local invoke only #7865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAM CLI shouldn't be mounting symlinks by default when building in a container
Which issue(s) does this change fix?
Why is this change necessary?
Symbolic links are used in SAM CLI to achieve faster build times with
build-in-source
. The build process creates symlinks for dependencies, that then can be used when runningsam local invoke
. These symlinks don't need to be mounted duringsam build
.How does it address the issue?
We add a new context property for the container to make a different decision depending on the context.
What side effects does this change have?
If SAM CLI users were relying on this behavior during builds, their workflow might get broken. Please create an issue if you're affected by this change, and we'll prioritize to add a new property to allow mounting symlinks in any case.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.