Remove const qualifier from send/recv in transport implementations and MQTT system test #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarenameas
reviewed
Oct 21, 2020
| @@ -177,7 +177,7 @@ OpensslStatus_t Openssl_Disconnect( const NetworkContext_t * pNetworkContext ); | |||
| * | |||
| * @return Number of bytes received if successful; negative value on error. | |||
| */ | |||
| int32_t Openssl_Recv( const NetworkContext_t * pNetworkContext, | |||
| int32_t Openssl_Recv( NetworkContext_t * pNetworkContext, | |||
There was a problem hiding this comment.
When MISRA is in CI we can make an annotation later for this I suppose.
sarenameas
approved these changes
Oct 21, 2020
dan4thewin
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submodule pointers are updated to follow changes from changes from FreeRTOS/coreMQTT#86, FreeRTOS/coreHTTP#45, & FreeRTOS/FreeRTOS@398abba. The const qualifier is removed from send/recv because there are transport implementations that require a member of the network context to be modified such as in the case of mbedtls.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.