-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(monocdk): export "core" types without a namespace #7007
Conversation
Move all the types from "@aws-cdk/core" to the root namespace of `monocdk-experiment`. Before: import { Construct } from 'monocdk-experiment/core'; // or import { core } from 'monocdk-experiment'; const Construct = core.Construct; After: import { Construct } from 'monocdk-experiment'; Update the @monocdk-experiment/rewrite-imports tool to use the new "barrel imports" and respect the fact that core types are non-namespace. Update @monocdk-experiment/assert accordingly.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
packages/@monocdk-experiment/rewrite-imports/bin/rewrite-imports.ts
Outdated
Show resolved
Hide resolved
…ts.ts Co-Authored-By: Romain Marcadier-Muller <rmuller@amazon.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Commit Message
Move all the types from "@aws-cdk/core" to the root namespace of
monocdk-experiment
.Before:
After:
Update the @monocdk-experiment/rewrite-imports tool to use the new "barrel imports" and respect the fact that core types are non-namespace.
Update @monocdk-experiment/assert accordingly.
End of Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license