-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create A Tag Management for Constructs #538
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e0cef90
feat(cdk): Tagging support via TagManager (#538)
moofish32 e4a0fb6
cleaning up code via comments
moofish32 e7a17cb
cleaning up tests
moofish32 24da7ac
code cleanup
moofish32 6658fc9
moving public DEFAULT_TAG_PROPS to private, fixing indentation
moofish32 8e79a7e
adding TagManager doc
moofish32 12d1d02
Merge branch 'master' into f-tag-manager
moofish32 6ec468e
adding details about tag removal
moofish32 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ export interface ITaggable { | |
export type Tags = { [key: string]: string }; | ||
|
||
/** | ||
* A an object of tags with value and properties | ||
* An object of tags with value and properties | ||
* | ||
* This is used internally but not exported | ||
*/ | ||
|
@@ -65,7 +65,28 @@ export interface RemoveProps { | |
* | ||
* Each construct that wants to support tags should implement the `ITaggable` | ||
* interface and properly pass tags to the `Resources` (Cloudformation) elements | ||
* the `Construct` creates using `toCloudformation()` for lazy evaluations | ||
* the `Construct` creates. The `TagManager` extends `Token` the object can be | ||
* passed directly to `Resources` that support tag properties. | ||
* | ||
* There are a few standard use cases the `TagManager` supports for managing | ||
* tags across the resources in your stack. | ||
* | ||
* Propagation: If you tag a resource and it has children, by default those tags | ||
* will be propagated to the children. This is controlled by | ||
* `TagProps.propagate`. | ||
* | ||
* Default a tag unless an ancestor has a value: There are situations where a | ||
* construct author might want to set a tag value, but choose to take a parents | ||
* value. For example, you might default `{Key: "Compliance", Value: "None"}`, | ||
* but if a parent has `{Key: "Compliance", Value: "PCI"}` allow that parent to | ||
* override your tag. This is can be done by setting `TagProps.sticky` to false. | ||
* The default behavior is that child tags have precedence and `TagProps.sticky` | ||
* defaults to true to reflect this. | ||
* | ||
* Overwrite: Construct authors have the need to set a tag, but only if one was | ||
* not provided by the conumer. The most common example is the `Name` tag. | ||
* Overwrite is for this purpose and is controlled by `TagProps.overwrite`. The | ||
* default is `true`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @eladb -- this is my next attempt at describing the what, why, and how for |
||
*/ | ||
export class TagManager extends Token { | ||
|
||
|
@@ -88,7 +109,7 @@ export class TagManager extends Token { | |
private readonly _tags: FullTags = {}; | ||
|
||
/* | ||
* Tags that will be reomved during `tags` method | ||
* Tags that will be removed during `tags` method | ||
*/ | ||
private readonly blockedTags: string[] = []; | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conumer => consumer