Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(batch): corrected the documentation string for updateToLatestImageVersion in ManagedComputeEnvironmentProps. #33594

Conversation

ashishdhingra
Copy link
Contributor

Issue # (if applicable)

Closes #33582.

Reason for this change

Documentation string for updateToLatestImageVersion in ManagedComputeEnvironmentProps was incorrect w.r.t. changes introduced in diff.

Description of changes

Corrected the documentation string for updateToLatestImageVersion in ManagedComputeEnvironmentProps. (taken from IManagedComputeEnvironment)

Describe any new or updated permissions being added

N/A

Description of how you validated changes

N/A (simple documentation fix)

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ageVersion in ManagedComputeEnvironmentProps.
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (e220bc8) to head (72901df).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33594   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 26, 2025
Copy link
Contributor

mergify bot commented Feb 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 72901df
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 528e5df into main Feb 28, 2025
20 checks passed
Copy link
Contributor

mergify bot commented Feb 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the updateToLatestImageVersion-ManagedComputeEnvironmentProps-DocStringFix branch February 28, 2025 00:02
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
3 participants