Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): add support for newer aurora postgresql versions and deprecate out-of-support versions #27731

Merged
merged 7 commits into from
Nov 27, 2023

Conversation

veho-mac
Copy link
Contributor

@veho-mac veho-mac commented Oct 27, 2023

Added newly supported aurora rds postgres versions, as well as deprecated versions no longer supported by aws.

Versions added: 11.20, 11.21, 12.15, 12.16, 13.11, 13.12, 14.9, 15.4.

Aurora Postgres Versions


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 27, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 27, 2023 18:18
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@veho-mac
Copy link
Contributor Author

Exemption Request

These are purely enum changes

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 30, 2023
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!
You should change the title to chore(rds): ....
This will also disable linter checks for tests and README updates (not necessary in this case).
Also, can you add a reference to the list of Aurora Postgres versions in the description?

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 2, 2023
@veho-mac veho-mac changed the title feat(rds): add support for aurora postgresql 11.20, 11.21, 12.15, 12.16, 13.11, 13.12, 14.9, 15.4 and deprecate version out-of-support chore(rds): add support for aurora postgresql 11.20, 11.21, 12.15, 12.16, 13.11, 13.12, 14.9, 15.4 and deprecate version out-of-support Nov 6, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 6, 2023 17:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@veho-mac
Copy link
Contributor Author

veho-mac commented Nov 6, 2023

@lpizzinidev Added your suggestions!

@vinayak-kukreja
Copy link
Contributor

Hey, thank you for opening this PR.

Could you please check if we are using deprecated versions in our unit and/or integ tests. If so, could you update those.

If you are unable to run the integ tests, please let me know and I can run those for you.

@vinayak-kukreja vinayak-kukreja removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 7, 2023
@vinayak-kukreja vinayak-kukreja self-assigned this Nov 7, 2023
@vinayak-kukreja vinayak-kukreja changed the title chore(rds): add support for aurora postgresql 11.20, 11.21, 12.15, 12.16, 13.11, 13.12, 14.9, 15.4 and deprecate version out-of-support chore(rds): add support for newer aurora postgresql versions and deprecate out-of-support versions Nov 7, 2023
@vinayak-kukreja
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 10, 2023

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/issue-label-assign.yml without workflows permission

Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is great! Thank you for your contribution. I have verified the integ tests.

Copy link
Contributor

mergify bot commented Nov 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 27, 2023
@mergify mergify bot dismissed vinayak-kukreja’s stale review November 27, 2023 22:59

Pull request has been modified.

Copy link
Contributor

mergify bot commented Nov 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 25ac0ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 04eaa54 into aws:main Nov 27, 2023
Copy link
Contributor

mergify bot commented Nov 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants