chore(prlint): trigger pr linter from pr reviews #26535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
added
the
pr/needs-maintainer-review
mrgrain
reviewed
Jul 27, 2023
kaizencc
commented
Jul 27, 2023
Co-authored-by: Momo Kornher <mail@moritzkornher.de>
mrgrain
reviewed
Jul 27, 2023
| @@ -25,8 +68,8 @@ jobs: | |||
| statuses: read | |||
| issues: read | |||
| runs-on: ubuntu-latest | |||
| needs: download-if-workflow-run | |||
There was a problem hiding this comment.
Doesn't this mean download-if-workflow-run always has to run and complete?
There was a problem hiding this comment.
yes but as far as i can tell, in order to get an output from a previous step you must depend on that step
There was a problem hiding this comment.
so right now if its not a workflow run i skip all individual steps of download-if-workflow-run (but do not skip the job)
mrgrain
reviewed
Jul 27, 2023
kaizencc
commented
Jul 27, 2023
Co-authored-by: Momo Kornher <mail@moritzkornher.de>
mrgrain
approved these changes
Jul 27, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ends up being a lot of work. Essentially, the
pull_request_reviewtrigger runs the action on the merge branch which does not have the necessary secrets. This workflow has been inspired from github docs on what to do in this situation.The PR linter takes the commit sha and pr number from the
pull_request_targetworkflow and assumes that those values are available. So we will take those values frompull_request_review, upload them as artifacts and then download them when the pr linter action is triggered by the workflow run.The code in
index.tshasn't been tested, but should work.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license