fix(s3): allow empty string as keyPrefixEquals

[dbartholomae]

Closes #26242 .

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[mrgrain]

Looks good. I'll run the integ test soon.

[mrgrain]

@dbartholomae
For some reason I can't push to your branch, so here's a patch file.

0001-integ-test.patch

[dbartholomae]

Thanks! Not sure why you couldn't push, the checkmark to allow edits is set.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mrgrain]

Thanks! Not sure why you couldn't push, the checkmark to allow edits is set.

Yeah this might be an issue on my end. Not that I have figured it out yet. Anecdotally I can push to other forks...

[mrgrain]

Something else is failing on the PR now btw!

[dbartholomae]

Seems like an integration test for lambda-python-alpha is failing. While it could potentially be related to the PR, as lambda assets are deployed via S3 buckets, I don't really see how it could be. Here's the error:

@aws-cdk/aws-lambda-python-alpha: ERROR: failed to solve: process "/bin/sh -c python -m venv /usr/app/venv &&     mkdir /tmp/pip-cache &&     chmod -R 777 /tmp/pip-cache &&     pip install --upgrade pip &&     mkdir /tmp/poetry-cache &&     chmod -R 777 /tmp/poetry-cache &&     pip install pipenv==2022.4.8 poetry &&     rm -rf /tmp/pip-cache/* /tmp/poetry-cache/*" did not complete successfully: exit code: 4294967295
@aws-cdk/aws-lambda-python-alpha: /codebuild/output/src612331878/src/github.com/aws/aws-cdk/packages/aws-cdk-lib/core/lib/private/asset-staging.js:187
@aws-cdk/aws-lambda-python-alpha:         throw new Error([
@aws-cdk/aws-lambda-python-alpha:         ^
@aws-cdk/aws-lambda-python-alpha: Error: docker exited with status 1
@aws-cdk/aws-lambda-python-alpha: --> Command: docker build -t cdk-10b67f2b3e1cb903b12b787ccfc006d1aae3850584e656bf5624e7ccc49f810c --platform "linux/amd64" --build-arg "IMAGE=public.ecr.aws/sam/build-python3.8" "/codebuild/output/src612331878/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/lib"
@aws-cdk/aws-lambda-python-alpha:     at dockerExec (/codebuild/output/src612331878/src/github.com/aws/aws-cdk/packages/aws-cdk-lib/core/lib/private/asset-staging.js:187:15)
@aws-cdk/aws-lambda-python-alpha:     at Function.fromBuild (/codebuild/output/src612331878/src/github.com/aws/aws-cdk/packages/aws-cdk-lib/core/lib/bundling.js:221:40)
@aws-cdk/aws-lambda-python-alpha:     at new Bundling (/codebuild/output/src612331878/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/lib/bundling.js:39:50)
@aws-cdk/aws-lambda-python-alpha:     at Function.bundle (/codebuild/output/src612331878/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/lib/bundling.js:25:50)
@aws-cdk/aws-lambda-python-alpha:     at new PythonFunction (/codebuild/output/src612331878/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/lib/function.js:43:39)
@aws-cdk/aws-lambda-python-alpha:     at new TestStack (/codebuild/output/src612331878/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/test/integ.function.sub.js:15:20)
@aws-cdk/aws-lambda-python-alpha:     at Object.<anonymous> (/codebuild/output/src612331878/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/test/integ.function.sub.js:28:18)
@aws-cdk/aws-lambda-python-alpha:     at Module._compile (node:internal/modules/cjs/loader:1196:14)
@aws-cdk/aws-lambda-python-alpha:     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1250:10)
@aws-cdk/aws-lambda-python-alpha:     at Module.load (node:internal/modules/cjs/loader:1074:32)
@aws-cdk/aws-lambda-python-alpha:   ERROR      integ.function.sub 33.438s
@aws-cdk/aws-lambda-python-alpha:       Command exited with status 1

@mrgrain I'll try to take this to your Contributor Office hours next week :)

[mrgrain]

It's unrelated, I'm investigating this at the moment. You can add an empty commit to force a re-run, or update from main.

[dbartholomae]

Thanks, that worked!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 4d5e791
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).