Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v1 version updates, including breaking changes in jsii #22387

Merged
merged 3 commits into from
Oct 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ describe('auto scaling group', () => {
expect(asg.node.defaultChild instanceof autoscaling.CfnAutoScalingGroup).toEqual(true);
});

test('can set blockDeviceMappings', () => {
testDeprecated('can set blockDeviceMappings', () => {
// GIVEN
const stack = new cdk.Stack();
const vpc = mockVpc(stack);
Expand Down
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-cloudfront/test/origin-groups.test.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { Match, Template } from '@aws-cdk/assertions';
import * as s3 from '@aws-cdk/aws-s3';
import { testDeprecated } from '@aws-cdk/cdk-build-tools';
import * as cdk from '@aws-cdk/core';
import { CloudFrontWebDistribution, FailoverStatusCode } from '../lib';

describe('origin group', () => {
test('Distribution with custom origin failover', () => {
testDeprecated('Distribution with custom origin failover', () => {
const stack = new cdk.Stack();

new CloudFrontWebDistribution(stack, 'ADistribution', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ NQIDAQAB

describe('web distribution', () => {

test('distribution with custom origin adds custom origin', () => {
testDeprecated('distribution with custom origin adds custom origin', () => {
const stack = new cdk.Stack();

new CloudFrontWebDistribution(stack, 'AnAmazingWebsiteProbably', {
Expand Down Expand Up @@ -410,7 +410,7 @@ added the ellipsis so a user would know there was more to r...`,
});


test('distribution with trusted signers on default distribution', () => {
testDeprecated('distribution with trusted signers on default distribution', () => {
const stack = new cdk.Stack();
const sourceBucket = new s3.Bucket(stack, 'Bucket');
const pubKey = new PublicKey(stack, 'MyPubKey', {
Expand Down
32 changes: 32 additions & 0 deletions packages/@aws-cdk/aws-lambda-nodejs/test/testtsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"compilerOptions": {
"declarationMap": false,
"inlineSourceMap": true,
"inlineSources": true,
"alwaysStrict": true,
"charset": "utf8",
"declaration": true,
"experimentalDecorators": true,
"incremental": true,
"lib": [
"es2020"
],
"module": "CommonJS",
"newLine": "lf",
"noEmitOnError": true,
"noFallthroughCasesInSwitch": true,
"noImplicitAny": true,
"noImplicitReturns": true,
"noImplicitThis": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"resolveJsonModule": true,
"strict": true,
"strictNullChecks": true,
"strictPropertyInitialization": true,
"stripInternal": false,
"target": "ES2020",
"composite": true,
"tsBuildInfoFile": "tsconfig.tsbuildinfo"
}
}
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-lambda-nodejs/test/util.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ describe('extractDependencies', () => {

describe('getTsconfigCompilerOptions', () => {
test('should extract compiler options and returns as string', () => {
const tsconfig = path.join(__dirname, '..', 'tsconfig.json');
const tsconfig = path.join(__dirname, 'testtsconfig.json');
const compilerOptions = getTsconfigCompilerOptions(tsconfig);
expect(compilerOptions).toEqual([
'--alwaysStrict',
Expand Down