Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oauth token as param to codebuild.GitHubEnterpriseSource #907

Closed
eaddingtonwhite opened this issue Oct 11, 2018 · 2 comments
Closed

Add oauth token as param to codebuild.GitHubEnterpriseSource #907

eaddingtonwhite opened this issue Oct 11, 2018 · 2 comments

Comments

@eaddingtonwhite
Copy link
Contributor

Currently codebuild.GitHubEnterpriseSource does not let me pass oauth token like we can for codebuild.GitHubSource

I want to be able to do something like this.

new codebuild.Project(stack, 'Project', {
  source: new codebuild.GitHubEnterpriseSource("https://mycompany.github.com", "my_oauth_token")
});

cc/ @moofish32
eaddingtonwhite added a commit to eaddingtonwhite/aws-cdk that referenced this issue Oct 11, 2018
@eaddingtonwhite
aws#907 Adds oauth token as param to codebuild.GitHubEnterpriseSource
feb94c1
@eaddingtonwhite eaddingtonwhite mentioned this issue Oct 11, 2018
Merged
@eaddingtonwhite
Copy link
Contributor Author

#908

eaddingtonwhite added a commit to eaddingtonwhite/aws-cdk that referenced this issue Oct 12, 2018
@eaddingtonwhite
aws#907 Makes codebuild github sources use cdk.Secret for oAuth token.
ddffe24
eaddingtonwhite added a commit to eaddingtonwhite/aws-cdk that referenced this issue Oct 12, 2018
@eaddingtonwhite
aws#907 Makes github codebuild sources take prop interface.
ee1b38c
eaddingtonwhite added a commit to eaddingtonwhite/aws-cdk that referenced this issue Oct 12, 2018
@eaddingtonwhite
aws#907 Adds test for codebuild github source.
6530d86
@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 12, 2018

Closed byt he PR I suppose?

@rix0rrr rix0rrr closed this as completed Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rix0rrr @eaddingtonwhite