fix(cli): notices for ranged alpha modules are not showing up correctly #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinZZ
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
GavinZZ
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 84.59% 84.61% +0.01%
==========================================
Files 198 204 +6
Lines 35380 35647 +267
Branches 4547 4583 +36
==========================================
+ Hits 29931 30163 +232
- Misses 5298 5336 +38
+ Partials 151 148 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rix0rrr
approved these changes
Feb 27, 2025
mrgrain
requested changes
Feb 27, 2025
packages/aws-cdk/test/cloud-assembly-trees/experimental-module-pre-release-semver/tree.json
Show resolved
Hide resolved
GavinZZ
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
mrgrain
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where notices don't show up when we define a range of pre-releases semver for alpha modules.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license