Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bootstrap): add DeletionPolicy and UpdateReplacePolicy to FileAssetsBucketEncryptionKey #100

Merged
merged 3 commits into from
Feb 28, 2025
Merged

fix(bootstrap): add DeletionPolicy and UpdateReplacePolicy to FileAssetsBucketEncryptionKey #100

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81f85f1
add DeletionPolicy and UpdateReplacePolicy
gracelu0 Feb 21, 2025
b5da9d5
Merge branch 'main' into update-bootstrap-template
gracelu0 Feb 25, 2025
02489c1
Merge branch 'main' into update-bootstrap-template
mrgrain Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/aws-cdk/lib/api/bootstrap/bootstrap-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ Resources:
Fn::Sub: "${FilePublishingRole.Arn}"
Resource: "*"
Condition: CreateNewKey
UpdateReplacePolicy: Delete
DeletionPolicy: Delete
FileAssetsBucketEncryptionKeyAlias:
Condition: CreateNewKey
Type: AWS::KMS::Alias
Expand Down Expand Up @@ -657,7 +659,7 @@ Resources:
Type: String
Name:
Fn::Sub: '/cdk-bootstrap/${Qualifier}/version'
Value: '25'
Value: '26'
Outputs:
BucketName:
Description: The name of the S3 bucket owned by the CDK toolkit stack
Expand Down