Controller gets stuck in a crash loop #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fawadkhaliq
suggested changes
Jul 15, 2020
| ServiceDiscovery: &appmesh.ServiceDiscovery{ | ||
| AWSCloudMap: &appmesh.AWSCloudMapServiceDiscovery{ | ||
| NamespaceName: "cloudmap-ns", | ||
| ServiceName: "cloudmap-svc", |
There was a problem hiding this comment.
Can we please also add coverage on the following:
- DNS<->CloudMap (should fail)
- DNS<->DNS (should pass)
There was a problem hiding this comment.
CloudMap->DNS is covered where it blocks if anything under awsCloudMap is changed as part of" VirtualNode field awsCloudMap changed". We will allow DNS->CloudMap however. Will add a test case for DNS->DNS.
There was a problem hiding this comment.
We will allow DNS->CloudMap however
I don't see how DNS->CloudMap is allowed here. Looking at the diff in virtualnode_validator.go, it'll block all: DNS->CloudMap, CloudMap->DNS and CloudMap->CloudMap(new)
Let's please also add a test for DNS->CloudMap as per the expected behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#305
Description of changes:
AWSCloudMap config of VirtualNode Spec is made immutable. Controller will allow ServiceDiscovery to be dynamically changed from DNS to CloudMap but not vice versa.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.