temporary fix to TCS API model #4503
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failed. New revision coming soon. |
xxx0624
approved these changes
Feb 13, 2025
aaithal
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation details
Reverting a change that came in commit 4471
Namely changing the TCS Metric API model from
BytesUtilized(Capitalized) back tobytesUtilized(lowercase)This change caused issues with TACS. We have an action item to investigate why the metrics ingestion service expects lowercase name when the model has always been Uppercase. This is a manual edit to temporarily fix the issue.
Testing
Fargate Agent End-to-End testing.
New tests cover the changes:
Description for the changelog
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No, but we should have this issue fixed before the next release.
Does this PR include the addition of new environment variables in the README?
NO
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.