[ec2tagger] Set refresh interval for describe volumes to 5m when configured #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisStark
reviewed
Mar 4, 2025
translator/tocwconfig/sampleConfig/standard_config_linux_with_common_config.yaml
Show resolved
Hide resolved
TravisStark
previously approved these changes
Mar 4, 2025
|
PR Build for windows is failing -- need to update windows translation unit tests |
musa-asad
reviewed
Mar 4, 2025
musa-asad
reviewed
Mar 4, 2025
musa-asad
previously approved these changes
Mar 4, 2025
…agent into ec2tagger-volumes
lisguo
dismissed stale reviews from musa-asad, Paramadon, and TravisStark
via
b106ac1
jefchien
reviewed
Mar 4, 2025
translator/translate/otel/processor/ec2taggerprocessor/translator.go
Outdated
Show resolved
Hide resolved
musa-asad
reviewed
Mar 4, 2025
lisguo
changed the title
|
Need to regenerate the sample config YAMLs. |
…agent into ec2tagger-volumes
…agent into ec2tagger-volumes
musa-asad
approved these changes
Mar 5, 2025
jefchien
approved these changes
Mar 5, 2025
musa-asad
pushed a commit
that referenced
this pull request
Mar 6, 2025
musa-asad
pushed a commit
that referenced
this pull request
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Currently refresh interval seconds is the config used for determining the interval for both tags and volumes. This PR will create two separate intervals: RefreshTagsInterval, and RefreshVolumesInterval. By default we will set the refresh interval for volumes to 5 minutes if VolumeId is configured as an append dimension. Tags will remain the same at 0.
Description of changes
RefreshIntervalSecondsconfig in ec2taggerRefreshTagsIntervalandRefreshVolumesIntervalin ec2taggerrefreshLoopToUpdateTagsAndVolumes()function into separate funcsrefreshLoopToUpdateTags()andrefreshLoopToUpdateVolumes()according to the intervalsLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Unit tests
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint