-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Log Group Cleanup to Clean up Action #1575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mann
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is huge for cost savings! would be nice to see some unit tests here, but other than that look sgood
jefchien
reviewed
Feb 28, 2025
0b86f64
to
9bdc496
Compare
jefchien
previously approved these changes
Mar 3, 2025
This reverts commit 9c3e660.
jefchien
previously approved these changes
Mar 3, 2025
the-mann
approved these changes
Mar 4, 2025
Paramadon
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
musa-asad
pushed a commit
that referenced
this pull request
Mar 6, 2025
musa-asad
pushed a commit
that referenced
this pull request
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This pull request introduces a new job to the GitHub Actions workflow for cleaning up old AWS CloudWatch log groups. The key changes include:
Workflow Changes
.github/workflows/clean-aws-resources.yml
clean-log-groups
to clean old CloudWatch log groups.New Feature
tool/clean/clean_log_group/clean_log_group.go
Dependency Updates
tool/clean/go.mod
github.com/aws/aws-sdk-go-v2
and added new dependencies forcloudwatchlogs
.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
go test ./clean_log_group -v
Requirements
Before committing the code, please complete the following steps:
make fmt
andmake fmt-sh
.make lint
.