Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync contrib to pull in emf translator fix #1570

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

sky333999
Copy link
Contributor

@sky333999 sky333999 commented Feb 25, 2025

Description of the issue

With the sync of OTel v115, we introduced an issue where the agent started to send non-metric EMF log events for Enhanced CI.
Sample log event that we wrongly start to publish:

{
  "ClusterName": "cwagent-eks-integ-ddd16a5ab68e7d10",
  "ContainerName": "main",
  "DCGM_FI_DEV_FB_FREE": 1,
  "DCGM_FI_DEV_FB_TOTAL": 1,
  "DCGM_FI_DEV_FB_USED": 1,
  "DCGM_FI_DEV_FB_USED_PERCENT": 1,
  "DCGM_FI_DEV_GPU_TEMP": 1,
  "DCGM_FI_DEV_GPU_UTIL": 1,
  "DCGM_FI_DEV_POWER_USAGE": 1,
  "FullPodName": "pod1-hash",
  "GpuDevice": "nvidia0",
  "Hostname": "ip-172-31-10-40.us-west-2.compute.internal",
  "InstanceId": "i-024a202d50a871fd9",
  "InstanceType": "t3.medium",
  "K8sPodName": "pod1-hash",
  "Namespace": "amazon-cloudwatch",
  "NodeName": "ip-172-31-10-40.us-west-2.compute.internal",
  "PodName": "pod1",
  "Timestamp": "1740433809643",
  "UUID": "uuid0",
  "Version": "0",
  "container": "main",
  "device": "nvidia0",
  "gpu": "0",
  "modelName": "Tesla T4",
  "namespace": "amazon-cloudwatch",
  "pod": "pod1-hash"
}

Description of changes

Sync contrib to pull in emf translator fix for the bad merge that restores the prior behavior where log events without actual CloudWatchMetrics are dropped for Enhanced CI.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

  • Contrib unit tests updated
  • Locally tested on a cluster

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@sky333999 sky333999 requested a review from a team as a code owner February 25, 2025 22:44
@sky333999 sky333999 merged commit 3d83201 into main Feb 25, 2025
7 checks passed
@sky333999 sky333999 deleted the sky333999/emf-translator-fix branch February 25, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants