-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: troubleshooting module - All scenarios #1182
Open
arcegacardenas
wants to merge
137
commits into
aws-samples:main
Choose a base branch
from
arcegacardenas:troubleshooting-module-all-scenarios
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
new: troubleshooting module - All scenarios #1182
arcegacardenas
wants to merge
137
commits into
aws-samples:main
from
arcegacardenas:troubleshooting-module-all-scenarios
+8,730
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es#1023) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ples#1024) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…les#1041) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…samples#1026) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…bsite guide for similar structure and language with eksworkshopv2.
… troubleshooting-module-all-scenarios-robisoh88
… troubleshooting-module-all-scenarios
…hooting-module-all-scenarios
…ing-module-all-scenarios-robisoh88
…egacardenas/eks-workshop-v2 into troubleshooting-module-all-scenarios
… to follow and testing is consistent.
…aml port section for troubleshooting workernode scenario three
…ncomoc Update: Added steps to dns lab
…ing-module-all-scenarios-aicheck
…-scenarios-aicheck modify md files
- Modified cluster name from var.addon_context.eks_cluster_id to var.eks_cluster_id - Modified entire three module guide and its written format. Made minor changes to commands so output is more efficient and less verbose. - had to update ssm.sh script path on the guide to absolute path - fixed cleanup script to include deleting new-cni-nodegroup - identified issue where aws-node pod was not in pending state. Source issue was the node type. Modified nodetype for the new manage nodegroup from m5.large to c5.large.
….com/arcegacardenas/eks-workshop-v2 into troubleshooting-module-all-scenarios
- Modified cluster name from var.addon_context.eks_cluster_id to var.eks_cluster_id - Modified entire three module guide and its written format. Made minor changes to commands so output is more efficient and less verbose. - Updated ssm.sh script path on the guide to absolute path - Fixed cleanup script to include deleting new-cni-nodegroup - Identified issue where aws-node pod was not in pending state. Source issue was the node type. Modified nodetype for the new manage nodegroup from m5.large to c5.large. - Tested and confirmed all pass 'make test module' - Reviewed and modified DNS module guides to fit format better - Reviewed and modified Pod Module guides to fit format better - Tested against 'pre-commit run --show-diff-on-failure --color=always --all-files'
Testing troubleshooting worker node module - Had to update metrics-server.yaml and fix the deployment port from 4443 to 10250. This was causing metrics server pods to not run properly. Testing troubleshooting Pod modules - Updated guide Step 1 to include pod label, so it only outputs the efs-app pod. - Updated step 2 describe pod command to grep 'efs'. Since this exports pod name, previsouly it was exporting multiple pods in default namespace causing the scripts on other the steps to fail. - Modified step 5 get output since it was still pointint to variable which was reset by this time. Added pod lable to select the correct pod. Testing troubleshooting scenario for DNS - updated main page prepare environment script from 'prepare-environment troubleshooting/dns' to 'prepare-environment'. This scenario does not use terraform scripts and needs environment to be in original prepare-environment state. - updated kubectl get command for deployment CoreDNS to coredns on Step 3 of first scenario. This was causing a deployment not found message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a new module that helps troubleshoot common EKS scenarios.
Which issue(s) this PR fixes:
Fixes #906
Quality checks
make test module="<module>"
it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md) I ran each lab within the module individually due to a sts token expiration issue To make able to simulate the scenarios I had to test each individually.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.