Use feature flag in the start command #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[dev] Use feature flag in the start command
roystchiang
reviewed
Mar 6, 2025
terraform/ec2/amis.tf
Outdated
| @@ -36,7 +36,7 @@ variable "ami_family" { | |||
| otconfig_destination = "/tmp/ot-default.yml" | |||
| download_command_pattern = "curl %s --output aws-otel-collector.rpm" | |||
| install_command = "sudo rpm -Uvh aws-otel-collector.rpm" | |||
| start_command = "sudo /opt/aws/aws-otel-collector/bin/aws-otel-collector-ctl -c \"$(echo -n 'CONFIGURATION_URI_PLACEHOLDER' | base64 -d)\" -a start" | |||
| start_command = "sudo /opt/aws/aws-otel-collector/bin/aws-otel-collector-ctl -c \"$(echo -n 'CONFIGURATION_URI_PLACEHOLDER' | base64 -d)\" -f $FEATUREGATE_PLACEHOLDER -a start" | |||
There was a problem hiding this comment.
not familiar with terraform, but replace seems to just replace the string as is.
do we need the $ before FEATUREGATE_PLACEHOLDER?
There was a problem hiding this comment.
Terraform is replaces it as a literal string, hence it wouldn't be required, committed the changes.
roystchiang
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[dev] Use feature flag in the start command
cherry picking the commit from dev branch #1767
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.