Replace stringLeading method with Java 8 friendlty alternative #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majanjua-amzn
approved these changes
Oct 4, 2024
pxaws
approved these changes
Oct 5, 2024
musa-asad
pushed a commit
to musa-asad/aws-otel-java-instrumentation
that referenced
this pull request
Oct 8, 2024
…bservability#902) *Issue #, if available:* The stringLeading method is only available in Java 11+. This doesn't meet our requirement of ADOT Java being available for Java 8+. We need to find an alternative method. *Description of changes:* Refactor code to be Java 8 friendlty *Test run:* https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/11158858146 *Note* Previously, the test was failing Java 8 for EKS use case. With this new change, it is passing now. This proves that: 1. The function `getDBStatementRemoteOperation`, specfically `stripLeading()` is being tested by E2E test 2. The new change does not affect Java 11+ and also fixes Java 8 Unit tests also show that combinations of different attributes all pass ([Link](https://github.com/aws-observability/aws-otel-java-instrumentation/blob/main/awsagentprovider/src/test/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGeneratorTest.java#L573)) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The stringLeading method is only available in Java 11+. This doesn't meet our requirement of ADOT Java being available for Java 8+. We need to find an alternative method.
Description of changes:
Refactor code to be Java 8 friendlty
Test run:
https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/11158858146
Note
Previously, the test was failing Java 8 for EKS use case. With this new change, it is passing now.
This proves that:
getDBStatementRemoteOperation, specficallystripLeading()is being tested by E2E testUnit tests also show that combinations of different attributes all pass (Link)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.