-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@aws-amplify/datastore): configurable sync pagination limit #5181
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5181 +/- ##
==========================================
- Coverage 73.22% 73.17% -0.05%
==========================================
Files 193 193
Lines 11442 11449 +7
Branches 2302 2221 -81
==========================================
Hits 8378 8378
- Misses 2900 2923 +23
+ Partials 164 148 -16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the contribution @polymath-shpetim , it looks great 😄
I do have one change request though, can you rename paginationLimit
to syncPageSize
?
Updated code, thanks for feedback. Cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! thanks! 👍
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Allow user to configure sync pagination limit due to limit reach of 1MB if dynamodb documents are bigger. By reducing pagination limit it's possible to overcome following issue:
This pull request allow users to add such configuration as following:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.